Horton
Menu

Re: Proposal: add new API to stringinfo

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: dgrowleyml@gmail.com, gurjeet@singh.im, pgsql-hackers@postgresql.org, michael@paquier.xyz, andrew@dunslane.net
Date: 2025-01-08T17:49:45Z
Lists: pgsql-hackers 
On Tue, Jan 07, 2025 at 03:57:57PM +0900, Tatsuo Ishii wrote:
> So the v2 patch version is 1.3787% slower than master. Do you think we
> need further inlining?

If it's not too much work to coax the compiler to do so, then I don't see a
strong reason to avoid it.  Granted, there are probably much more expensive
parts of the StringInfo support functions (e.g., palloc()), but these are
hot enough code paths that IMHO it's worth saving whatever cycles we can.

-- 
nathan

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add new StringInfo APIs to allow callers to specify the buffer size.