Horton

Re: Fix a wrong errmsg in AlterRole()

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: cca5507 <cca5507@qq.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-08T17:39:31Z
Lists: pgsql-hackers 
On Wed, Jan 08, 2025 at 10:29:12AM -0500, Tom Lane wrote:
> "=?ISO-8859-1?B?Y2NhNTUwNw==?=" <cca5507@qq.com> writes:
>> postgres=&gt; alter group g1 drop user r1;
>> ERROR:  permission denied to alter role
>> DETAIL:  Only roles with the ADMIN option on role "g1" may add members.
> 
>> The errmsg is "add members", but we are doing a drop.
>> Here is a small patch to fix it.
> 
> Hmm.  Seems simpler to just make the errdetail say "... may add or
> drop members."

+1.  It looks like this goes back to commit ce6b672 (v16).  The error
message was changed in commit de4d456, which is also a v16 change, so
fortunately this has a good chance of back-patching cleanly.

-- 
nathan

Commits

  1. Fix an ALTER GROUP ... DROP USER error message.

  2. Improve several permission-related error messages.

  3. Make role grant system more consistent with other privileges.