Re: Fix a wrong comment in load_file()

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: cca5507 <cca5507@qq.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-23T03:42:25Z
Lists: pgsql-hackers
On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
> /* If the same shlib has previously been loaded, unload and reload it. */
> 
> But we currently don't support to unload a shlib.

  * This function loads a shlib file without looking up any particular
  * function in it.  If the same shlib has previously been loaded,
- * unload and reload it.
+ * we don't load it again.

Right.  This comment is misleading.

-	/* Load the shared library */
+	/* Load the shared library, unless we already did */
 	(void) internal_load_library(fullname);

This comment is still true, though.  internal_load_library() has some
logic to make sure that we don't load twice the same library on
repeated calls of the function as the file_list is checked.
--
Michael

Commits

  1. Fix some comments related to library unloading