Horton

Re: Memory leak in WAL sender with pgoutput (v10~)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, Euler Taveira <euler@eulerto.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-19T02:26:35Z
Lists: pgsql-hackers 
On Thu, Dec 19, 2024 at 07:50:57AM +0530, Amit Kapila wrote:
> The difference between fix_memory_leak_v2 and fix_memory_leak_v3 is
> that the earlier one resets the pubctx to NULL along with freeing the
> context memory. Resetting a file-level global variable is a good idea,
> similar to what we do for RelationSyncCache, so I prefer v2 over v3,
> but I am fine if you would like to proceed with v3.

FWIW, I am not OK with v3.  I've raised this exact point a couple of
days ago upthread:
https://www.postgresql.org/message-id/Z1t5pXsNEYwS4P5k@paquier.xyz

v2 does not have these weaknesses by design.
--
Michael

Commits

  1. Fix memory leak in pgoutput with relation attribute map

  2. Fix memory leak in pgoutput with publication list cache

  3. Allow specifying row filters for logical replication of tables.