Re: Outdated comment on scram_build_secret

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-10T00:58:28Z
Lists: pgsql-hackers
On Mon, Dec 09, 2024 at 08:39:03PM -0300, Matheus Alcantara wrote:
> Commit b577743000 introduced the assert and remove the if condition. All
> usages of this function is using an iteration > 0, so I think that is just a
> matter of updating the documentation? If that's the case the attached patch
> does that.

Ah, good catch.  

> - * If iterations is 0, default number of iterations is used.  The result is
> - * palloc'd or malloc'd, so caller is responsible for freeing it.
> + * The result is palloc'd or malloc'd, so caller is responsible for freeing it.

Removing the comment sounds like the right thing to do here.  I'll go
do that in a bit down to v16.
--
Michael

Commits

  1. Fix outdated comment of scram_build_secret()

  2. Make SCRAM iteration count configurable