Horton

Thread

Commits

  1. Fix unused-but-set-variable compiler warning in reorderbuffer.c.

  1. unused-but-set-variable warning on REL_13_STABLE

    Nathan Bossart <nathandbossart@gmail.com> — 2024-12-09T19:16:38Z

    My compiler emits the following warning on REL_13_STABLE when assertions
are disabled:

	reorderbuffer.c:2471:8: warning: variable 'spilled' set but not used [-Wunused-but-set-variable]
	 2471 |         Size            spilled = 0;
	      |                         ^

Adding PG_USED_FOR_ASSERTS_ONLY (as in the attached patch) seems sufficient
to suppress this warning.  On newer versions, this variable is used for
more than assertions, so the patch only needs to be applied to v13.  Since
this is trivial, I plan to commit it shortly.

-- 
nathan

  2. Re: unused-but-set-variable warning on REL_13_STABLE

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-12-09T19:39:30Z

    Nathan Bossart <nathandbossart@gmail.com> writes:
> Adding PG_USED_FOR_ASSERTS_ONLY (as in the attached patch) seems sufficient
> to suppress this warning.  On newer versions, this variable is used for
> more than assertions, so the patch only needs to be applied to v13.  Since
> this is trivial, I plan to commit it shortly.

LGTM

			regards, tom lane

  3. Re: unused-but-set-variable warning on REL_13_STABLE

    Nathan Bossart <nathandbossart@gmail.com> — 2024-12-09T22:28:36Z

    On Mon, Dec 09, 2024 at 02:39:30PM -0500, Tom Lane wrote:
> LGTM

Thanks!  Committed.

-- 
nathan