Re: Fix early elog(FATAL)

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Noah Misch <noah@leadboat.com>

Cc: pgsql-hackers@postgresql.org

Date: 2024-12-14T04:16:39Z

Lists: pgsql-hackers

On Fri, Dec 13, 2024 at 10:14:43PM -0600, Nathan Bossart wrote:
> On Fri, Dec 13, 2024 at 07:15:05PM -0800, Noah Misch wrote:
>> I don't feel strongly either way.  I did write it the option-1 way originally.
>> Then I started thinking about changes at a distance causing the other
>> InitProcessGlobals() tasks to palloc or elog.  We could do option-1 in master
>> and keep the back branches in their current state.
> 
> I don't feel strongly either way, either.  I don't think it's important
> enough to diverge from the back-branches.

Also, thank you for fixing this.

-- 
nathan

Commits

Fix elog(FATAL) before PostmasterMain() or just after fork().
- ac4a2b40392b 16.7 landed
- 839da50bd431 15.11 landed
- 6151769f6ef5 13.19 landed
- 4bd9de3f4190 17.3 landed
- 315264d70128 14.16 landed
- 8b9cbf492275 18.0 landed
Remove obsolete check in SIGTERM handler for the startup process.
- 8fd0498de200 17.0 cited
Check that MyProcPid == getpid() in backend signal handlers.
- 3b00fdba9f20 17.0 cited
Avoid calling proc_exit() in processes forked by system().
- 97550c071197 17.0 cited
Refactor pid, random seed and start time initialization.
- 197e4af9d5da 12.0 cited