Re: More CppAsString2() in psql's describe.c
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-28T06:34:55Z
Lists: pgsql-hackers
Attachments
- v2-0001-psql-Sprinkle-more-CppAsString2-in-describe.c.patch (text/x-diff) patch v2-0001
On Tue, Oct 22, 2024 at 09:49:10AM +0900, Michael Paquier wrote: > Note that there were a couple of value checks not part of the queries > that relied on values from the catalogs for some relpersistences and > replidents. I've fixed them while on it. > > Thoughts or comments are welcome. So, this one has been sitting in the CF for a couple of weeks now. I've looked at it again and the queries are written the same. There was one inconsistency with the ordering of the headers and one indentation issue with a query for extended stats. Any objections against applying it? This is the last area of the code where we rely on such hardcoded values rather than CppAsString2(). Note also the pg_am.h inclusion which is incorrect. -- Michael
Commits
-
psql: Sprinkle more CppAsString2() in describe.c
- 18954ce7f69b 18.0 landed