Horton

Re: Memory leak in WAL sender with pgoutput (v10~)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Euler Taveira <euler@eulerto.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-04T06:21:55Z
Lists: pgsql-hackers 
On Wed, Dec 04, 2024 at 11:05:43AM +0530, Amit Kapila wrote:
> On Wed, Dec 4, 2024 at 7:39 AM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> wrote:
>> It appears there is an additional memory leak caused by allocating publication
>> names within the CacheMemoryContext, as noted in [1]. And it can also be fixed by
>> creating a separate memctx for publication names under the logical decoding
>> context. I think the approach makes sense since the lifespan of publication
>> names should ideally align with that of the logical decoding context.
> 
> Yeah, I don't think we can go with the proposed patch for the local
> memory context as it is.

Ah, indeed.  I was missing your point.  Would any of you like to write
a patch to achieve that?
--
Michael

Commits

  1. Fix memory leak in pgoutput with relation attribute map

  2. Fix memory leak in pgoutput with publication list cache

  3. Allow specifying row filters for logical replication of tables.