Re: Use more CppAsString2() in pg_amcheck.c

On Mon, Nov 25, 2024 at 06:25:46PM +0300, Karina Litskevich wrote:
> The patch looks good to me.

Thanks for the review.

> They are not identical: space before AND vs space at the end of the
> previous line. I'd say that it would be better if they were
> identical. Personally, I prefer the one with a space before AND.
> Though we have two more similar cases in lines 1974-2001:
>
> And I'm not sure how they should be handled if we choose a space
> before AND. Does the following still look fine?
>
> What do you think?

Both look the same to me, TBH. :D

The result in the queries generated is also the same before and after
the patch.  I see the inconsistency in style, but I'm not sure that
it's worth bothering about that.  Applied v2.
--
Michael