Horton

Thread

Commits

  1. Drop "Lock" suffix from LWLock wait event names

  1. Drop back the redundant "Lock" suffix from LWLock wait event names

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2024-12-02T08:33:27Z

    Hi hackers,

da952b415f unintentionally added back the "Lock" suffix into the LWLock wait
event names:

- "added back" because the "Lock" suffix was removed in 14a9101091
- "unintentionally" because there is nothing in the thread [2] that explicitly
mentions that the idea was also to revert 14a9101091

Please find attached a patch to remove it back so that the pg_stat_activity
view now reports back the LWLock without the "Lock" suffix (as pg_wait_events
and the related documentation do).

It has been reported in bug #18728 (see [1]).

[1]: https://www.postgresql.org/message-id/flat/18728-450924477056a339%40postgresql.org
[2]: https://www.postgresql.org/message-id/flat/202401231025.gbv4nnte5fmm%40alvherre.pgsql

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  2. Re: Drop back the redundant "Lock" suffix from LWLock wait event names

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2024-12-02T13:22:49Z

    On 2024-Dec-02, Bertrand Drouvot wrote:

> Hi hackers,
> 
> da952b415f unintentionally added back the "Lock" suffix into the LWLock wait
> event names:
> 
> - "added back" because the "Lock" suffix was removed in 14a9101091
> - "unintentionally" because there is nothing in the thread [2] that explicitly
> mentions that the idea was also to revert 14a9101091

Oh, you're right, this was unintentional and unnoticed.  I'll push this
shortly, to both 17 and master.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

  3. Re: Drop back the redundant "Lock" suffix from LWLock wait event names

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2024-12-03T15:01:41Z

    On 2024-Dec-02, Alvaro Herrera wrote:

> Oh, you're right, this was unintentional and unnoticed.  I'll push this
> shortly, to both 17 and master.

Pushed, thanks Christophe and Bertrand.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
<Schwern> It does it in a really, really complicated way
<crab> why does it need to be complicated?
<Schwern> Because it's MakeMaker.