Horton
Menu

Re: Draft for basic NUMA observability

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Tomas Vondra <tomas@vondra.me>
Cc: "Shinoda, Noriyoshi (SXD Japan FSI)" <noriyoshi.shinoda@hpe.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Nazir Bilal Yavuz <byavuz81@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-09T18:59:14Z
Lists: pgsql-hackers

Attachments

Hi,

On Tue, Apr 08, 2025 at 12:46:16PM +0200, Tomas Vondra wrote:
> 
> 
> On 4/8/25 01:26, Shinoda, Noriyoshi (SXD Japan FSI) wrote:
> > Hi, 
> > 
> > Thanks for developing this great feature. 
> > The manual says that the 'size' column of the pg_shmem_allocations_numa view is 'int4', but the implementation is 'int8'. 
> > The attached small patch fixes the manual.
> > 
> 
> Thank you for noticing this and for the fix! Pushed.
> 
> This also reminded me we agreed to change page_num to bigint, which I
> forgot to change before commit. So I adjusted that too, separately.

I was doing some extra testing and just realized (did not think of it during the
review) that maybe we could add a pg_buffercache_numa usage example (like it's
already done for pg_buffercache).

That might sound obvious but OTOH I think that would not hurt.

Something like in the attached?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Correct pg_shmem_allocations_numa.size data type

  2. Add pg_buffercache_numa view with NUMA node info

  3. Add support for basic NUMA awareness

  4. Introduce pg_shmem_allocations_numa view