Re: Remove useless casts to (char *)

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Vladlen Popolitov <v.popolitov@postgrespro.ru>
Cc: Peter Eisentraut <peter@eisentraut.org>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-26T22:20:25Z
Lists: pgsql-hackers
On Wed, Mar 26, 2025 at 10:01:47PM +0700, Vladlen Popolitov wrote:
> I mentioned this patch in my message https://www.postgresql.org/message-id/f28f3b45ec84bf9dc99fe129023a2d6b%40postgrespro.ru
> Starting from it queries with Parallel Seq Scan (probably with other
> parallel executor nodes)
> hang under the debugger in Linux and MacOs.

Uh.  How could a simple cast impact a parallel seqscan?  That seems
unrelated to me.
--
Michael

Commits

  1. backend libpq void * argument for binary data

  2. SnapBuildRestoreContents() void * argument for binary data

  3. jsonb internal API void * argument for binary data

  4. backend launchers void * arguments for binary data

  5. Remove various unnecessary (char *) casts

  6. Remove unnecessary (char *) casts [xlog]

  7. XLogRegisterData, XLogRegisterBufData void * argument for binary data

  8. Remove unnecessary (char *) casts [checksum]

  9. Remove unnecessary (char *) casts [mem]

  10. Remove unnecessary (char *) casts [string]

  11. Make TLS write functions' buffer arguments pointers const