Horton

Re: Cannot find a working 64-bit integer type on Illumos

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra <tomas@vondra.me>, Heikki Linnakangas <hlinnaka@iki.fi>, Japin Li <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-25T21:33:59Z
Lists: pgsql-hackers 
On Tue, Mar 25, 2025 at 09:41:21PM +1300, Thomas Munro wrote:
> On Wed, Mar 5, 2025 at 6:00 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I agree with your patch 0001-Deprecate-pg_int64.patch.  I don't see a
>> reason to keep the current arrangement around pg_int64.
> 
> Thanks for looking!  Pushed.

anaconda seems to be upset about this one [0].  I've spent all of 30
seconds looking at it so far, but it appears to be using an old version of
the header file.

In file included from pg_regress.c:34:
/usr/local/include/libpq-fe.h:623:8: error: unknown type name 'pg_int64'
  623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence);
      |        ^
/usr/local/include/libpq-fe.h:623:50: error: unknown type name 'pg_int64'
  623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence);
      |                                                  ^
/usr/local/include/libpq-fe.h:627:8: error: unknown type name 'pg_int64'
  627 | extern pg_int64 lo_tell64(PGconn *conn, int fd);
      |        ^
/usr/local/include/libpq-fe.h:629:48: error: unknown type name 'pg_int64'
  629 | extern int      lo_truncate64(PGconn *conn, int fd, pg_int64 len);
      |                                                     ^
4 errors generated.

[0] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anaconda&dt=2025-03-25%2021%3A22%3A33

-- 
nathan

Commits

  1. Move pg_int64 back to postgres_ext.h

  2. pgbench: Make set_random_seed() 64-bit everywhere.

  3. Use PRI?64 instead of "ll?" in format strings (continued).

  4. Fix order of -I switches for building pg_regress.o.

  5. libpq: Deprecate pg_int64.

  6. Use PRI*64 instead of "ll*" in format strings (minimal trial)

  7. Fix header inclusion order in c.h.

  8. Use <stdint.h> and <inttypes.h> for c.h integers.

  9. Remove traces of BeOS.

  10. More correct way to check for existence of types, which allows to specify