Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Julien Rouhaud <rjuju123@gmail.com>
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sami Imseih <samimseih@gmail.com>, Michael Paquier <michael@paquier.xyz>, Christoph Berg <myon@debian.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, ma lz <ma100@hotmail.com>
Date: 2025-03-25T05:28:39Z
Lists: pgsql-hackers
On Tue, Mar 25, 2025 at 01:17:22AM -0400, Tom Lane wrote: > Julien Rouhaud <rjuju123@gmail.com> writes: > > On Tue, Mar 25, 2025 at 12:32:05AM -0400, Tom Lane wrote: > >> 2. Tools that are not entitled to set the value of the GUC are forced > >> to be prepared to cope with any setting. That can be anywhere from > >> painful to impossible. > > > Didn't that ship already sailed in pg14 when we allowed generating custom > > query_id? > > Up to a point, perhaps. If I'm writing some kind of tool that digests > pg_stat_statements results, I think I'm entitled to disregard the > possibility that somebody is using a custom query_id that behaves in > ways I'm not expecting --- or at least, fixing my code for that is > their problem not mine. But it's much harder to take that attitude > for things that are built into core PG. I see, that's fair.