Horton

Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 'Amit Kapila' <amit.kapila16@gmail.com>
Date: 2022-09-27T00:36:22Z
Lists: pgsql-hackers 
On Mon, Sep 26, 2022 at 04:50:36PM +0900, Michael Paquier wrote:
> You are right.  bool is not usually a problem in a signal handler, but
> sig_atomic_t is the type we ought to use.  I'll go adjust that.

Done this one.  I have scanned the code, but did not notice a similar
mistake.  It is worth noting that we have only one remaining "volatile
bool" in the headers now.
--
Michael

Commits

  1. Mark sigint_interrupt_enabled as sig_atomic_t

  2. Mark ParallelMessagePending as sig_atomic_t