Horton

Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 'Amit Kapila' <amit.kapila16@gmail.com>
Date: 2022-09-26T07:50:36Z
Lists: pgsql-hackers 
On Mon, Sep 26, 2022 at 06:57:28AM +0000, kuroda.hayato@fujitsu.com wrote:
> While reviewing [1], I and Amit noticed that a flag ParallelMessagePending is defined
> as "volatile bool", but other flags set by signal handlers are defined as "volatile sig_atomic_t".
> 
> How do you think?

You are right.  bool is not usually a problem in a signal handler, but
sig_atomic_t is the type we ought to use.  I'll go adjust that.
--
Michael

Commits

  1. Mark sigint_interrupt_enabled as sig_atomic_t

  2. Mark ParallelMessagePending as sig_atomic_t