Horton

Thread

Commits

  1. Remove definition of JUMBLE_SIZE from queryjumble.h

  1. JUMBLE_SIZE macro in two files

    bt22nakamorit <bt22nakamorit@oss.nttdata.com> — 2022-10-04T08:41:12Z

    Hi,

queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition 
in queryjumble.c should be deleted.
Thoughts?

Tatsu

  2. Re: JUMBLE_SIZE macro in two files

    Julien Rouhaud <rjuju123@gmail.com> — 2022-10-04T10:46:23Z

    Hi,

On Tue, Oct 04, 2022 at 05:41:12PM +0900, bt22nakamorit wrote:
>
> queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
> Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition in
> queryjumble.c should be deleted.

+1

  3. Re: JUMBLE_SIZE macro in two files

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-10-04T13:16:44Z

    bt22nakamorit <bt22nakamorit@oss.nttdata.com> writes:
> queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
> Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition 
> in queryjumble.c should be deleted.

I would go more for taking it out of queryjumble.h.  I see no
reason why that constant needs to be world-visible.

			regards, tom lane

  4. Re: JUMBLE_SIZE macro in two files

    Michael Paquier <michael@paquier.xyz> — 2022-10-05T03:12:53Z

    On Tue, Oct 04, 2022 at 09:16:44AM -0400, Tom Lane wrote:
> I would go more for taking it out of queryjumble.h.  I see no
> reason why that constant needs to be world-visible.

I was just looking at the patch before seeing your reply, and thought
the exact same thing.  Perhaps you'd prefer apply that yourself?
--
Michael

  5. Re: JUMBLE_SIZE macro in two files

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-10-05T03:17:09Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Oct 04, 2022 at 09:16:44AM -0400, Tom Lane wrote:
>> I would go more for taking it out of queryjumble.h.  I see no
>> reason why that constant needs to be world-visible.

> I was just looking at the patch before seeing your reply, and thought
> the exact same thing.  Perhaps you'd prefer apply that yourself?

Nah, feel free.

			regards, tom lane

  6. Re: JUMBLE_SIZE macro in two files

    Michael Paquier <michael@paquier.xyz> — 2022-10-05T05:29:56Z

    On Tue, Oct 04, 2022 at 11:17:09PM -0400, Tom Lane wrote:
> Nah, feel free.

Okay, thanks.  Applied, then.
--
Michael