Horton

Re: use has_privs_of_role() for pg_hba.conf

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Joe Conway <mail@joeconway.com>
Date: 2022-10-06T08:09:42Z
Lists: pgsql-hackers 
On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>> Good catch, I think this is a logical followup to the previous
>> has_privs_of_role patch.
>> 
>> Reviewed and +1
> 
> Thanks!  I created a commitfest entry for this:

This patch looks simple, but it is a very sensitive area so I think
that we should be really careful.  pg_hba.conf does not have a lot of
test coverage, so I'd really prefer if we add something to see the
difference of behavior and check the behavior that we are switching
here.  What I have just committed in 051b096 would help a bit here,
actually, and changing pg_hba.conf rules with rule reload is cheap.

Joe, you are registered as a reviewer and committer of this patch, by
the way.  Are you planning to look at it?
--
Michael

Commits

  1. Add TAP tests for role membership in pg_hba.conf