Horton

Re: pg_create_logical_replication_slot argument incongruency

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Florin Irion <irionr@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-09-20T01:33:24Z
Lists: pgsql-hackers 
On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
> This was introduced in commit 19890a06.
> 
> IMHO we should use the documented argument name `two_phase` and change the
> function to accept it.
> 
> What do you think?

19890a0 is included in REL_14_STABLE, and changing an argument name is
not acceptable in a stable branch as it would imply a catversion
bump.  Let's change the docs so as we document the parameter as
"twophase", instead.
--
Michael

Commits

  1. doc: Fix parameter name for pg_create_logical_replication_slot()

  2. Add option to enable two_phase commits via pg_create_logical_replication_slot.