Horton

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Daniel Gustafsson <daniel@yesql.se>, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2022-09-11T00:28:54Z
Lists: pgsql-hackers

Attachments

On Fri, Sep 09, 2022 at 08:11:09PM +0900, Michael Paquier wrote:
> Based on what I can see, the Windows animals seem to have digested
> 47bd0b3 (cygwin, MinGW and MSVC), so I think that we are good.

The last part that's worth adjusting is ldap_start_tls_sA(), which
would lead to the attached simplification.  The MinGW headers list
this routine, so like the previous change I think that it should be
safe for such builds.

Looking at the buildfarm animals, bowerbird, jacana, fairywren,
lorikeet and drongo disable ldap.  hamerkop is the only member that
provides coverage for it, still that's a MSVC build.

The CI provides coverage for ldap as it is enabled by default and
windows_build_config.pl does not tell otherwise, but with the existing
animals we don't have ldap coverage under MinGW.

Anyway, I'd like to apply the attached, and I don't quite see why it
would not work after 47bd0b3 under MinGW.  Any thoughts?
--
Michael

Commits

  1. doc: Fix incorrect version list for Windows SDK

  2. Replace loading of ldap_start_tls_sA() by direct function call

  3. Replace load of functions by direct calls for some WIN32

  4. Cleanup more code and comments related to Windows NT4 (XP days)

  5. Make Windows 10 the minimal runtime requirement for WIN32