Re: pg_receivewal and SIGTERM
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Christoph Berg <myon@debian.org>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-22T00:42:50Z
Lists: pgsql-hackers
On Fri, Aug 19, 2022 at 05:34:56PM +0530, Bharath Rupireddy wrote: > +1 to add "some" info in the docs (I'm not sure about the better > wording though), we can try to be more specific of the use case if > required. Yes, the amount of extra docs provided by the patch proposed by Christoph looks fine by me. FWIW, grouping the signal handlers into a common area like streamutil.c seems rather confusing to me, as they set different variable names that rely on their own assumptions in their local file, so I would leave that out, like the patch. While looking at the last patch proposed, it strikes me that time_to_stop should be sig_atomic_t in pg_receivewal.c, as the safe type of variable to set in a signal handler. We could change that, while on it.. Backpatching this stuff is not an issue here. -- Michael
Commits
-
Handle SIGTERM in pg_receivewal and pg_recvlogical
- 8b60db774356 16.0 landed
-
doc: Add missing parenthesis to keycombo
- 6cbed0ec791f 16.0 landed
- 207fc7546644 15.0 landed