Re: [PATCH] Add native windows on arm64 support
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Niyas Sait <niyas.sait@linaro.org>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-29T23:48:38Z
Lists: pgsql-hackers
On Mon, Aug 29, 2022 at 10:12:20AM +0900, Michael Paquier wrote: > I have noticed that yesterday, but cannot think much about it. This > basically changes the position of "<!--c1-->" for the first record, > leaving the second one untouched: > <!--c1--><?pi arg?><![CDATA[&ent1]]> > <?pi arg?><![CDATA[&ent1]]><!--c1--> > > I am not used to xmltable(), but I wonder if there is something in one > of these support functions in xml.c that gets influenced by the > randomization. That sounds a bit hairy as make check passed in > bowerbird, and I have noticed at least two other Windows hosts running > TAP that passed. Or that's just something with libxml itself. This is amazing. The issue has showed up a second time in a row in bowerbird, as of: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2022-08-29%2013%3A30%3A32 I don't know what to think about ASLR that manipulates the comment in this XML object under VS 2017 (perhaps a compiler issue?), but it should be possible to go back to green simply by removing "<!--c1-->" from the input string. Creating an extra output pattern here would be very costly, as xml_2.out and xml.out have outputs for --with-libxml. Would people object if I do that for now? -- Michael
Commits
-
MSVC: Support building for AArch64.
- a516b3f00d74 19 (unreleased) landed
-
Remove "#ifdef WIN32" guards from src/port/win32*.c
- 09eb633e1baa 17.0 cited
-
Adjust XML test case to avoid unstable behavior.
- 4ea07e7cf3c6 16.0 landed
-
Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds
- 36389a060ca6 16.0 landed