Horton

Re: Bug fix. autovacuum.c do_worker_start() associates memory allocations with TopMemoryContext rather than 'Autovacuum start worker (tmp)'

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, reid.thompson@crunchydata.com, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-01T00:35:05Z
Lists: pgsql-hackers 
On Wed, Aug 31, 2022 at 01:09:22PM -0700, Andres Freund wrote:
> On 2022-08-31 16:05:03 -0400, Tom Lane wrote:
>> Even if there's only a visible leak in v15/HEAD, I'm inclined
>> to back-patch this all the way, because it's certainly buggy
>> on its own terms.  It's just the merest accident that neither
>> caller is leaking other stuff into TopMemoryContext, because
>> they both think they are using a short-lived context.
> 
> +1

Ouch.  Thanks for the quick fix and the backpatch.
--
Michael

Commits

  1. Prevent long-term memory leakage in autovacuum launcher.