Re: fix stale help message
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-14T10:16:57Z
Lists: pgsql-hackers
On Wed, Aug 10, 2022 at 11:32:18PM +0800, Junwang Zhao wrote:
> when parsing command-line options, the -f option support disabling
> 8 scan and join methods, o, b and t disable index-only scans,
> bitmap index scans, and TID scans respectively, add them to the
> help message.
>
> @@ -351,7 +351,7 @@ help(const char *progname)
> printf(_(" -?, --help show this help, then exit\n"));
>
> printf(_("\nDeveloper options:\n"));
> - printf(_(" -f s|i|n|m|h forbid use of some plan
> types\n"));
> + printf(_(" -f s|i|o|b|t|n|m|h forbid use of some plan
> types\n"));
> printf(_(" -n do not reinitialize shared
> memory after abnormal exit\n"));
> printf(_(" -O allow system table structure
> changes\n"));
> printf(_(" -P disable system indexes\n"));
set_plan_disabling_options() is telling that you have all of them, as
much as the docs. I don't mind fixing that as you suggest, FWIW.
--
Michael
Commits
-
Fix outdated --help message for postgres -f
- 1a05596eaaaa 10.23 landed
- 6e086bb1dbeb 11.18 landed
- e2915afbd701 12.13 landed
- bcf7eb99bbf1 13.9 landed
- 63b64d827069 14.6 landed
- a5d233700582 15.0 landed
- f2108d3bd03d 16.0 landed