Re: pg_receivewal and SIGTERM

Christoph Berg <myon@debian.org>

From: Christoph Berg <myon@debian.org>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-19T10:54:34Z
Lists: pgsql-hackers
Re: Bharath Rupireddy
>     <application>pg_receivewal</application> will exit with status 0 when
> -   terminated by the <systemitem>SIGINT</systemitem> signal.  (That is the
> +   terminated by the <systemitem>SIGINT</systemitem> or
> +   <systemitem>SIGTERM</systemitem> signal.  (That is the
>     normal way to end it.  Hence it is not an error.)  For fatal errors or
>     other signals, the exit status will be nonzero.
> 
> Can we specify the reason in the docs why a SIGTERM causes (which
> typically would cause a program to end with non-zero exit code)
> pg_receivewal and pg_recvlogical exit with zero exit code? Having this
> in the commit message would help developers but the documentation will
> help users out there.

We could add "because you want that if it's running as a daemon", but
TBH, I'd rather remove the parentheses part. It sounds too much like
"it works that way because that way is the sane way".

Christoph



Commits

  1. Handle SIGTERM in pg_receivewal and pg_recvlogical

  2. doc: Add missing parenthesis to keycombo