Horton

Re: Backup command and functions can cause assertion failure and segmentation fault

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-01T00:33:16Z
Lists: pgsql-hackers 
On Wed, Jul 20, 2022 at 03:49:17PM +0900, Michael Paquier wrote:
> Adding an extra test to cover the second scenario is easier.  So I
> have added one as of the attached, addressing your other comments
> while on it.  I have also decided to add the tests at the bottom of
> 001_stream_rep.pl, as these are quicker than a node initialization.

Hearing nothing, I have looked at that again and applied the two tests
on HEAD as of ad34146.
--
Michael

Commits

  1. Add more TAP tests with BASE_BACKUP and pg_backup_start/stop

  2. Fix assertion failure and segmentation fault in backup code.

  3. Prevent BASE_BACKUP in the middle of another backup in the same session.