Horton

Thread

Commits

  1. Tweak detail and hint messages to be consistent with project policy

  1. errdetail/errhint style

    Justin Pryzby <pryzby@telsasoft.com> — 2022-07-19T12:09:48Z

    Most of these are new in v15.
In any case, I'm not sure if the others ought to be backpatched.
There may be additional fixes to make with the same grepping.

  2. Re: errdetail/errhint style

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2022-07-19T12:31:28Z

    On 2022-Jul-19, Justin Pryzby wrote:

> https://www.postgresql.org/docs/current/error-style-guide.html#id-1.10.6.4.7
> 
> git grep 'errdetail("[[:lower:]]'
> git grep 'errdetail(".*".*;' |grep -v '\."'

Hmm, +1, though a few of these are still missing ending periods after
your patch.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                                                           (Paul Graham)

  3. Re: errdetail/errhint style

    Michael Paquier <michael@paquier.xyz> — 2022-07-19T12:51:13Z

    On Tue, Jul 19, 2022 at 02:31:28PM +0200, Alvaro Herrera wrote:
> Hmm, +1, though a few of these are still missing ending periods after
> your patch.

+1.
--
Michael

  4. Re: errdetail/errhint style

    Michael Paquier <michael@paquier.xyz> — 2022-07-20T01:30:08Z

    On Tue, Jul 19, 2022 at 09:51:13PM +0900, Michael Paquier wrote:
> +1.

I have looked at that and added the extra periods, and applied it.
Thanks, Justin.
--
Michael