Re: defGetBoolean - Fix comment
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-07T00:54:24Z
Lists: pgsql-hackers
On Thu, Jul 07, 2022 at 09:53:01AM +1000, Peter Smith wrote: > Really this code is for the case when there *was* a parameter given > (e.g. "copy_data" in my example above) but when there is no parameter > *value* given. > > Suggested comment fix: > BEFORE > If no parameter given, assume "true" is meant. > AFTER > If no parameter value given, assume "true" is meant. Still, I think that your adjustment is right, as the check is, indeed, on the DefElem's value*. Or you could just say "If no value given". -- Michael
Commits
-
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 landed