Horton

Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still commits after client-side error

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <christoph.berg@credativ.de>, Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2022-07-05T00:12:03Z
Lists: pgsql-bugs 
On Mon, Jul 04, 2022 at 04:38:26PM +0200, Christoph Berg wrote:
> Is there anything left to do to fix up the --single_transaction +
> ON_ERROR_STOP case here? From reading the code, it now does what it
> should do. What is left to do for backpatching it?

As per upthread, Tom and Robert do not seem to agree on this point.
And it is true that this creates a behavior change.  At this stage, it
could be a good idea to gather more votes.
--
Michael

Commits

  1. Tweak behavior of psql --single-transaction depending on ON_ERROR_STOP

  2. Doc: remove a04ccf6df from release notes, now that it's reverted.

  3. Revert "Fix psql's single transaction mode on client-side errors with -c/-f switches".

  4. Fix psql's single transaction mode on client-side errors with -c/-f switches