Horton
Menu

Re: Add --{no-,}bypassrls flags to createuser

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "Shinya11.Kato@oss.nttdata.com" <Shinya11.Kato@oss.nttdata.com>, "przemyslaw@sztoch.pl" <przemyslaw@sztoch.pl>, "david.g.johnston@gmail.com" <david.g.johnston@gmail.com>, "robertmhaas@gmail.com" <robertmhaas@gmail.com>, "daniel@yesql.se" <daniel@yesql.se>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2022-07-13T23:39:58Z
Lists: pgsql-hackers 
On Wed, Jul 13, 2022 at 11:38:03AM -0700, Nathan Bossart wrote:
> On Wed, Jul 13, 2022 at 08:14:28AM +0000, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
>> The attached small patch fixes the message in "createuser --help"
>> command. The patch has changed to specify a time stamp for the
>> --valid-for option. I don't think the SGML description needs to be
>> modified.

Thanks, Shinoda-san.  Fixed.

> Good catch.  Apart from a nitpick about the indentation, your patch looks
> reasonable to me.

FWIW, one can check that with a simple `git diff --check` or similar
to see what was going wrong here.  This simple trick allows me to find
quickly formatting issues in any patch posted.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix output of createuser --help with --valid-until

  2. createuser: Add support for more clause types through new options

  3. createuser: Cleanup and fix internal option ordering

  4. Add REPLICATION privilege for ROLEs