Re: Logging query parmeters in auto_explain
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-06-28T07:54:24Z
Lists: pgsql-hackers
Attachments
- v5-0001-Refactor-TAP-test-of-auto_explain.patch (text/x-diff) patch v5-0001
- v5-0002-Log-query-parameters-in-auto_explain.patch (text/x-diff) patch v5-0002
On Mon, Jun 27, 2022 at 12:27:57PM +0100, Dagfinn Ilmari Mannsåker wrote: > I forgot to mention, I also changed the order of the query and > parameters, so that they can more naturally be left out when no changes > are needed. I can see that, and I have added $node as an extra parameter of the routine. After putting my hands on that, it also felt a bit unnatural to do the refactoring of the tests and the addition of the new GUC in the same patch, so I have split things as the attached. The amount of coverage is still the same but it makes the integration of the feature easier to follow. -- Michael
Commits
-
autho_explain: Add GUC to log query parameters
- d4bfe4128170 16.0 landed
-
Refactor the TAP test of auto_explain
- 550bc0a6c0c6 16.0 landed