Re: [PATCH] Completed unaccent dictionary with many missing characters
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Przemysław Sztoch <przemyslaw@sztoch.pl>
Cc: Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2022-06-28T05:14:53Z
Lists: pgsql-hackers
On Thu, Jun 23, 2022 at 02:10:42PM +0200, Przemysław Sztoch wrote: > The only division that is probably possible is the one attached. Well, the addition of cyrillic does not make necessary the removal of SOUND RECORDING COPYRIGHT or the DEGREEs, that implies the use of a dictionnary when manipulating the set of codepoints, but that's me being too picky. Just to say that I am fine with what you are proposing here. By the way, could you add a couple of regressions tests for each patch with a sample of the characters added? U+210C is a particularly sensitive case, as we should really make sure that it maps to what we want even if Latin-ASCII.xml tells a different story. This requires the addition of a couple of queries in unaccent.sql with the expected output updated in unaccent.out. -- Michael
Commits
-
Simplify a bit the special rules generating unaccent.rules
- e3dd7c06e627 16.0 landed