Re: Logging query parmeters in auto_explain
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-06-29T00:17:49Z
Lists: pgsql-hackers
On Tue, Jun 28, 2022 at 10:12:18AM +0100, Dagfinn Ilmari Mannsåker wrote: > That makes sense, but I still think the query_log() function definition > should go at the end (after done_testing()), so the machinery doesn't > distract from what's actually being tested. The majority of TAP scripts have their subroutines at the beginning of the script, and there are few having that at the end. I won't fight you on that, but the former is more consistent. > Also, the second paragraph of the second commit message now belongs in > the first commit (without the word "Also"). Yep, will fix. I usually rewrite commit messages before merging them. -- Michael
Commits
-
autho_explain: Add GUC to log query parameters
- d4bfe4128170 16.0 landed
-
Refactor the TAP test of auto_explain
- 550bc0a6c0c6 16.0 landed