Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-16T06:14:16Z
Lists: pgsql-hackers

Attachments

On Thu, Jun 09, 2022 at 02:47:36PM +0900, Michael Paquier wrote:
> On Thu, Jun 09, 2022 at 04:55:45PM +1200, Thomas Munro wrote:
>> I think we can drop mention of Itanium (RIP): the ancient versions of
>> Windows that could run on that arch are desupported with your patch.
>> It might be more relevant to say that we can't yet run on ARM, and
>> Windows 11 is untested by us, but let's fix those problems instead of
>> documenting them :-)
> 
> Okay to remove the Itanium part for me.

install-windows.sgml has one extra spot mentioning Windows 7 and
Server 2008 that can be simplified on top of that.

>> There are more mentions of older Windows releases near the compiler
>> stuff but perhaps your MSVC version vacuuming work will take care of
>> those.
> 
> Yes, I have a few changes like the one in main.c for _M_AMD64.  Are
> you referring to something else?

Actually, this can go with the bump of MIN_WINNT as it uses one of the
IsWindows*OrGreater() macros as a runtime check.  And there are two
more places in pg_ctl.c that can be similarly cleaned up.

It is possible that I have missed some spots, of course.
--
Michael

Commits

  1. doc: Fix incorrect version list for Windows SDK

  2. Replace loading of ldap_start_tls_sA() by direct function call

  3. Replace load of functions by direct calls for some WIN32

  4. Cleanup more code and comments related to Windows NT4 (XP days)

  5. Make Windows 10 the minimal runtime requirement for WIN32