Horton

Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bruce Momjian <bruce@momjian.us>
Cc: Christophe Pettus <xof@thebuild.com>, Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Петър Славов <pet.slavov@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-05-27T00:00:23Z
Lists: pgsql-bugs 
On Thu, May 26, 2022 at 10:48:27AM -0400, Bruce Momjian wrote:
> I assume we are then looking at reindexdb, which has a parallel option. 
> I assume we can also recommend --concurrently on a patched PG 14.4,
> which might not be terrible since it would not cause downtime.  I guess
> the command would be:
> 
> 	$ reindexdb --all --concurrently --jobs ##
> 
> Without reindexdb's features, this would be much more painful.

Worth noting that CONCURRENTLY is not supported on system catalogs so
these are safe from the start, and that reindexdb skips the parallel
processing of catalogs when using --jobs and --concurrently.  So that
would be non-intrusive. 
--
Michael

Commits

  1. Revert changes to CONCURRENTLY that "sped up" Xmin advance

  2. Fix possible HOT corruption when RECENTLY_DEAD changes to DEAD while pruning.