Horton

Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h}

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Georgios <gkokolatos@protonmail.com>
Date: 2022-04-11T22:50:29Z
Lists: pgsql-hackers 
On Mon, Apr 11, 2022 at 11:15:46AM -0400, Robert Haas wrote:
> +1 for this in general, but I think that naming like
> "compression_algo" stinks. If you think "compression_algorithm" is too
> long, I think you should use "algorithm" or "compression" or
> "compression_method" or something.

Yes, I found "compression_algorithm" to be too long initially.  For
walmethods.c and pg_receivewal.c, it may be better to just stick to
"algorithm"  then, at least that's consistent with pg_basebackup.c.
--
Michael

Commits

  1. Handle compression level in pg_receivewal for LZ4

  2. Rework compression options of pg_receivewal

  3. Remove WalCompressionMethod in favor of pg_compress_algorithm

  4. Rename backup_compression.{c,h} to compression.{c,h}