Re: Windows now has fdatasync()
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-04-08T07:10:49Z
Lists: pgsql-hackers
On Fri, Apr 08, 2022 at 12:40:55AM -0400, Tom Lane wrote: > As long as the C11-isms are in MSVC-only code, it seems like this is > exactly equivalent to setting a minimum MSVC version. I don't see > an objection-in-principle there, it's just a practical question of > how far back is reasonable to support MSVC versions. (That's very > distinct from how far back we need the built code to run.) Good question. Older versions of VS are available, so this is not a problem: https://visualstudio.microsoft.com/vs/older-downloads/ I think that we should at least drop 2013, as there is a bunch of stuff related to _MSC_VER < 1900 that could be removed with that, particularly for locales. -- Michael
Commits
-
Remove configure probe for fdatasync.
- d2e150831af8 16.0 landed
-
Remove O_FSYNC and associated macros.
- a1b56090eb54 16.0 landed
-
Fix warnings on Windows.
- bde60daa0ec9 16.0 landed
-
Add wal_sync_method=fdatasync for Windows.
- 9430fb407bb6 16.0 landed