Re: Windows now has fdatasync()
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-04-08T04:35:02Z
Lists: pgsql-hackers
On Fri, Apr 08, 2022 at 02:56:15PM +1200, Thomas Munro wrote: > I propose that we drop support for Windows versions older than > 10/Server 2016 in the PostgreSQL 16 cycle, because the OS patches for > everything older come to an end in October next year[1], and we have a > lot of patches relating to modern Windows features that stall on > details about old systems that no one actually has. > > [1] https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions Do you think that we could raise the minimum C standard on WIN32 to C11, at least for MSVC? There is a patch floating around to add pg_attribute_aligned() and perhaps pg_attribute_noreturn() for MSVC: https://www.postgresql.org/message-id/Yk6UgCGlZKuxRr4n@paquier.xyz noreturn() needed at least C11: https://docs.microsoft.com/en-us/cpp/c-language/noreturn?view=msvc-140 Perhaps we'd better also bump up the minimum version of MSVC supported.. -- Michael
Commits
-
Remove configure probe for fdatasync.
- d2e150831af8 16.0 landed
-
Remove O_FSYNC and associated macros.
- a1b56090eb54 16.0 landed
-
Fix warnings on Windows.
- bde60daa0ec9 16.0 landed
-
Add wal_sync_method=fdatasync for Windows.
- 9430fb407bb6 16.0 landed