Horton

Re: pg_tablespace_location() failure with allow_in_place_tablespaces

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-03-17T07:39:52Z
Lists: pgsql-hackers 
On Thu, Mar 17, 2022 at 07:55:30PM +1300, Thomas Munro wrote:
> I don't really want to spill details of this developer-only stuff onto
> more manual sections...  It's not really helping users if we confuse
> them with irrelevant details of a feature they shouldn't be using, is
> it?  And the existing treatment "Returns the file system path that
> this tablespace is located in" is not invalidated by this special
> case, so maybe we shouldn't mention it?

Right, I see your point.  The existing description is not wrong
either.  Fine by me to just drop all that.
--
Michael

Commits

  1. Remove unnecessary Windows-specific basebackup code.

  2. Fix get_dirent_type() for Windows junction points.

  3. doc: Remove mention to in-place tablespaces for pg_tablespace_location()

  4. Fix pg_tablespace_location() with in-place tablespaces

  5. Fix pg_basebackup with in-place tablespaces.