Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: okano.naoki@jp.fujitsu.com, pgsql-bugs@lists.postgresql.org
Date: 2022-03-26T05:46:45Z
Lists: pgsql-bugs, pgsql-hackers
On Fri, Mar 25, 2022 at 07:52:57AM +0000, PG Bug reporting form wrote: > On this page (*) says that in Windows 10, version 1703 and later OS > versions, > you must specify the FILE_MAP_LARGE_PAGES flag with the MapViewOfFile > function > to map large pages. > > I think it seems to be the cause that MapViewOfFile() in > src/backend/port/win32_shmem.c > does not specify FILE_MAP_LARGE_PAGES flag. Hmm. Okay. A patch would be straight-forward, as we could just assign the optional flag in a separate variable at the beginning of PGSharedMemoryCreate(), similarly to flProtect when we find out that large pages can be used, then pass it down to MapViewOfFileEx(). I don't have a Windows 10 machine as recent as that at hand, though.. Perhaps the CI uses Windows machines that would allow to test and check that, with some logs magically added to debug things. -- Michael
Commits
-
Fix huge_pages on Windows
- fdd8937c071e 16.0 landed