Re: wal_compression=zstd

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>
Date: 2022-03-07T06:36:31Z
Lists: pgsql-hackers
On Fri, Mar 04, 2022 at 08:10:35AM -0500, Andrew Dunstan wrote:
> I don't see why patch 5 shouldn't be applied forthwith.

Only applying 0005 would result in a failure in the TAP test for a
problem whose fix is attempted in 0006.  This is an issue unrelated to
this thread.

FWIW, I am a bit disturbed by EnsureTopTransactionIdLogged() and its
design in 0006, where we'd finish by using a XLogFlush() call within
two SQL functions, but I have not really looked at the problem to see
if it is a viable solution or not.
--
Michael

Commits

  1. Bump XLOG_PAGE_MAGIC due to the addition of wal_compression=zstd

  2. Add support for zstd with compression of full-page writes in WAL