Horton

Re: PATCH: add "--config-file=" option to pg_rewind

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Gunnar \"Nick\" Bluth" <gunnar.bluth@pro-open.de>
Cc: Daniel Gustafsson <daniel@yesql.se>, Alexander Kukushkin <cyberdemn@gmail.com>, Aleksander Alekseev <aleksander@timescale.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, x4mmm@yandex-team.ru, kondratovaleksey@gmail.com
Date: 2022-03-01T04:18:23Z
Lists: pgsql-hackers 
On Mon, Feb 28, 2022 at 08:48:23PM +0100, Gunnar "Nick" Bluth wrote:
> So, how should we call the global "find the ***** 'postgres' executable and
> boil out if that fails" function?
>     char postgres_exec_path[MAXPGPATH] = findPostgresExec();
> ?

That would mean only a couple of lines gained, and the readability
gained is minimal, so I'd be fine to keep the code as-is.  I am not
sure about the full patch set yet, but the refactoring of the commands
to use PQExpBuffer is good by itself, so I have extracted this part of
the patch and applied that for now.
--
Michael

Commits

  1. Add option --config-file to pg_rewind

  2. Rework internal command generation of pg_rewind