Horton

Re: pg_stop_backup() v2 incorrectly marked as proretset

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-03-02T10:04:17Z
Lists: pgsql-hackers

Attachments

On Wed, Mar 02, 2022 at 05:22:35PM +0900, Kyotaro Horiguchi wrote:
> But the patch forgets to remove an useless variable.

Indeed.  I forgot to look at stderr.

>>	/* Initialise attributes information in the tuple descriptor */
>>	tupdesc = CreateTemplateTupleDesc(PG_STOP_BACKUP_V2_COLS);
>>	TupleDescInitEntry(tupdesc, (AttrNumber) 1, "lsn",
>>					   PG_LSNOID, -1, 0);
> 
> I think we can use get_call_resuilt_type here.

Yes, I don't mind doing so here.
--
Michael

Commits

  1. Fix catalog data of pg_stop_backup(), labelled v2