pg_stop_backup() v2 incorrectly marked as proretset
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-03-02T07:46:01Z
Lists: pgsql-hackers
Attachments
- stopbackup-no-srf.patch (text/x-diff) patch
Hi all, In my hunt looking for incorrect SRFs, I have noticed a new case of a system function marked as proretset while it builds and returns only one record. And this is a popular one: pg_stop_backup(), labelled v2. This leads to a lot of unnecessary work, as the function creates a tuplestore it has no need for with the usual set of checks related to SRFs. The logic can be be simplified as of the attached. Thoughts? -- Michael
Commits
-
Fix catalog data of pg_stop_backup(), labelled v2
- 62ce0c758d5d 15.0 landed