Re: Replacing TAP test planning with done_testing()
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-10T00:58:27Z
Lists: pgsql-hackers
On Wed, Feb 09, 2022 at 02:49:47PM -0500, Tom Lane wrote: > =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes: >> Daniel Gustafsson <daniel@yesql.se> writes: >>> The attached patch removes all Test::More planning and instead ensures that all >>> tests conclude with a done_testing() call. While there, I also removed a few >>> exit(0) calls from individual tests making them more consistent. > >> LGTM, +1. > > LGTM too. Not tested, but +1. Could it be possible to backpatch that even if this could be qualified as only cosmetic? Each time a test is backpatched we need to tweak the number of tests planned, and that may change slightly depending on the branch dealt with. -- Michael
Commits
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 landed