Horton

Re: Ensure that STDERR is empty during connect_ok

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2022-02-06T07:00:58Z
Lists: pgsql-hackers 
On Wed, Feb 02, 2022 at 03:40:39PM +0100, Daniel Gustafsson wrote:
> As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by
> inspecting STDERR in connect_ok and require it to be empty.  This is not really
> NSS specific, and could help find issues in other libraries as well so I
> propose to apply it regardless of the fate of the NSS patchset.

Sounds sensible from here.  Thanks!

All the code paths seem to be covered, at quick glance.
--
Michael

Commits

  1. Ensure that STDERR is empty in connect_ok tests

  2. Require version 0.98 of Test::More for TAP tests