Horton

Re: pg_upgrade should truncate/remove its logs before running

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-01-20T10:51:37Z
Lists: pgsql-hackers 
On Thu, Jan 20, 2022 at 10:31:15AM +0100, Peter Eisentraut wrote:
> I'm afraid that is too easily confused with the target directory. Generally,
> a tool processes data from input to output or from source to target or
> something like that, whereas a log is more clearly something separate from
> this main processing stream.  The desired "output" of pg_upgrade is the
> upgraded cluster, after all.
> 
> A wildcard idea is to put the log output into the target cluster.

Neat idea.  That would work fine for my case.  So I am fine to stick
with this suggestion. 
--
Michael

Commits

  1. pg_upgrade: Move all the files generated internally to a subdirectory