Horton

Re: pg_upgrade should truncate/remove its logs before running

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-01-24T01:59:40Z
Lists: pgsql-hackers

Attachments

On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote:
> Neat idea.  That would work fine for my case.  So I am fine to stick
> with this suggestion. 

I have been looking at this idea, and the result is quite nice, being
simpler than anything that has been proposed on this thread yet.  We
get a simpler removal logic, and there is no need to perform any kind
of sanity checks with the output path provided as long as we generate
the paths and the dirs after adjust_data_dir().

Thoughts?
--
Michael

Commits

  1. pg_upgrade: Move all the files generated internally to a subdirectory