Re: pgsql: Refactor tar method of walmethods.c to rely on the compression m

Christoph Berg <myon@debian.org>

From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-01-07T14:41:16Z
Lists: pgsql-hackers
Re: Michael Paquier
> Refactor tar method of walmethods.c to rely on the compression method

Hi,

since about this commit, pg_wal.tar is no longer compressed at all:

$ pg_basebackup -D foo --format=tar
$ ls -l foo/
-rw-------  1 cbe cbe   137152  7. Jan 15:37 backup_manifest
-rw-------  1 cbe cbe 23606272  7. Jan 15:37 base.tar
-rw-------  1 cbe cbe 16778752  7. Jan 15:37 pg_wal.tar

$ pg_basebackup -D foogz --format=tar --gzip
$ ls -l foogz
-rw-------  1 cbe cbe   137152  7. Jan 15:37 backup_manifest
-rw-------  1 cbe cbe  3073257  7. Jan 15:37 base.tar.gz
-rw-------  1 cbe cbe 16779264  7. Jan 15:37 pg_wal.tar     <-- should be pg_wal.tar.gz

Christoph



Commits

  1. Fix thinko coming from 000f3adf

  2. Refactor tar method of walmethods.c to rely on the compression method